From d6877c27fd005b286b4e34f57c58e54fdac88807 Mon Sep 17 00:00:00 2001
From: digua <i@digua.me>
Date: Sun, 9 Aug 2026 18:07:22 +0800
Subject: [PATCH] fix(memory): keep index load failures non-destructive

Show a retry-only state when summary index reads fail so transient errors cannot expose the full rebuild action and erase summaries. Also align newly added implementation comments with repository style.
---
 packages/node-runtime/src/ai/summary/index.ts |  2 +-
 .../common/ChatRecord/ChatRecordDrawer.vue    |  4 +-
 .../common/ChatRecord/ChatRecordWorkspace.vue | 42 ++++++++++++++++---
 .../common/ChatRecord/SessionTimeline.vue     |  4 +-
 .../common/ChatRecord/query-session.ts        |  2 +-
 .../common/ChatRecord/workspace-state.test.ts | 20 +++++++++
 .../common/ChatRecord/workspace-state.ts      | 13 ++++++
 src/i18n/locales/en-US/records.json           |  4 +-
 src/i18n/locales/ja-JP/records.json           |  4 +-
 src/i18n/locales/zh-CN/records.json           |  4 +-
 src/i18n/locales/zh-TW/records.json           |  4 +-
 11 files changed, 88 insertions(+), 15 deletions(-)
 create mode 100644 src/components/common/ChatRecord/workspace-state.test.ts
 create mode 100644 src/components/common/ChatRecord/workspace-state.ts

diff --git a/packages/node-runtime/src/ai/summary/index.ts b/packages/node-runtime/src/ai/summary/index.ts
index 0a0e0576..5a0a654f 100644
--- a/packages/node-runtime/src/ai/summary/index.ts
+++ b/packages/node-runtime/src/ai/summary/index.ts
@@ -308,7 +308,7 @@ export async function generateSessionSummary(
     summary = postProcessSummary(summary, lengthLimit)
     deps.saveSummary(segmentId, summary)
 
-    // 摘要属于用户聊天内容，日志只记录定位故障所需的元数据，避免持久化明文。
+    // Summaries contain private chat data, so persist only diagnostic metadata in logs.
     log?.info('Summary', `Summary generated for segment ${segmentId} (${summary.length} characters)`)
     return { success: true, summary }
   } catch (error) {
diff --git a/src/components/common/ChatRecord/ChatRecordDrawer.vue b/src/components/common/ChatRecord/ChatRecordDrawer.vue
index 410b5355..a3ef17fa 100644
--- a/src/components/common/ChatRecord/ChatRecordDrawer.vue
+++ b/src/components/common/ChatRecord/ChatRecordDrawer.vue
@@ -1,7 +1,7 @@
 <script setup lang="ts">
 /**
- * 聊天记录查看器 Drawer
- * 保留快速查看入口，完整的记录编排由 ChatRecordWorkspace 复用。
+ * Chat record viewer drawer.
+ * Keeps the quick-view shell while ChatRecordWorkspace owns shared orchestration.
  */
 import { ref, onMounted } from 'vue'
 import { useI18n } from 'vue-i18n'
diff --git a/src/components/common/ChatRecord/ChatRecordWorkspace.vue b/src/components/common/ChatRecord/ChatRecordWorkspace.vue
index 8fa6f058..a1337883 100644
--- a/src/components/common/ChatRecord/ChatRecordWorkspace.vue
+++ b/src/components/common/ChatRecord/ChatRecordWorkspace.vue
@@ -1,8 +1,9 @@
 <script setup lang="ts">
 /**
- * 聊天记录工作区
+ * Shared chat record workspace.
  *
- * Drawer 和“记忆 → 记录”共用同一套连续消息流、摘要时间线与左右滚动联动。
+ * The drawer and Memory > Records reuse the continuous message stream,
+ * summary timeline, and bidirectional scroll synchronization.
  */
 import { computed, nextTick, ref, toRaw, watch } from 'vue'
 import { useI18n } from 'vue-i18n'
@@ -15,6 +16,7 @@ import MessageList from './MessageList.vue'
 import SessionTimeline from './SessionTimeline.vue'
 import type { ChatRecordQuery } from './types'
 import { preserveChatRecordSessionId, resolveChatRecordSessionId, scopeChatRecordQueryToSession } from './query-session'
+import { resolveChatRecordIndexAction, type ChatRecordIndexAction, type ChatRecordIndexState } from './workspace-state'
 
 const props = withDefaults(
   defineProps<{
@@ -41,12 +43,15 @@ const timelineCollapsed = ref(false)
 const activeSessionId = ref<number | undefined>()
 const sessionsCache = ref<ChatSessionItem[]>([])
 const matchedSessionIds = ref<Set<number> | undefined>()
-const indexState = ref<'loading' | 'ready' | 'missing' | 'error'>('loading')
+const indexState = ref<ChatRecordIndexState>('loading')
 const isGeneratingIndex = ref(false)
 const timelineVersion = ref(0)
 let initializationVersion = 0
 
 const isPageMode = computed(() => props.mode === 'page')
+const indexAction = computed<ChatRecordIndexAction>(() =>
+  isPageMode.value ? resolveChatRecordIndexAction(indexState.value) : null
+)
 const fallbackSessionId = computed(() => props.sessionId || currentSessionId.value)
 const effectiveSessionId = computed(() => resolveChatRecordSessionId(localQuery.value, fallbackSessionId.value))
 
@@ -165,7 +170,7 @@ function handleSessionsUpdated(sessions: ChatSessionItem[]) {
 
 async function generateIndex() {
   const sessionId = effectiveSessionId.value
-  if (!sessionId || isGeneratingIndex.value) return
+  if (!sessionId || isGeneratingIndex.value || indexAction.value !== 'generate') return
 
   isGeneratingIndex.value = true
   try {
@@ -199,7 +204,7 @@ watch([() => props.active, fallbackSessionId, () => props.initialQuery], () => i
       />
 
       <div
-        v-if="isPageMode && (indexState === 'missing' || indexState === 'error')"
+        v-if="indexAction === 'generate'"
         class="flex shrink-0 items-start justify-between gap-4 border-b border-amber-200/70 bg-amber-50/80 px-4 py-3 dark:border-amber-800/50 dark:bg-amber-950/20"
       >
         <div class="flex min-w-0 gap-3">
@@ -226,6 +231,33 @@ watch([() => props.active, fallbackSessionId, () => props.initialQuery], () => i
         </UButton>
       </div>
 
+      <div
+        v-else-if="indexAction === 'retry'"
+        class="flex shrink-0 items-start justify-between gap-4 border-b border-red-200/70 bg-red-50/80 px-4 py-3 dark:border-red-800/50 dark:bg-red-950/20"
+      >
+        <div class="flex min-w-0 gap-3">
+          <UIcon name="i-heroicons-exclamation-circle" class="mt-0.5 h-5 w-5 shrink-0 text-red-600 dark:text-red-400" />
+          <div class="min-w-0">
+            <p class="text-sm font-medium text-red-900 dark:text-red-100">
+              {{ t('records.workspace.indexLoadFailedTitle') }}
+            </p>
+            <p class="mt-0.5 text-xs leading-relaxed text-red-700 dark:text-red-300">
+              {{ t('records.workspace.indexLoadFailedDescription') }}
+            </p>
+          </div>
+        </div>
+        <UButton
+          class="shrink-0"
+          color="error"
+          variant="soft"
+          size="sm"
+          icon="i-heroicons-arrow-path"
+          @click="initializeWorkspace"
+        >
+          {{ t('common.retry') }}
+        </UButton>
+      </div>
+
       <div class="flex min-h-0 flex-1">
         <SessionTimeline
           v-if="effectiveSessionId"
diff --git a/src/components/common/ChatRecord/SessionTimeline.vue b/src/components/common/ChatRecord/SessionTimeline.vue
index 2ed8418e..3308f327 100644
--- a/src/components/common/ChatRecord/SessionTimeline.vue
+++ b/src/components/common/ChatRecord/SessionTimeline.vue
@@ -35,9 +35,9 @@ const emit = defineEmits<{
   (e: 'select', sessionId: number, firstMessageId: number): void
   /** 折叠状态变化 */
   (e: 'update:collapsed', value: boolean): void
-  /** 单条摘要更新，供共享工作区同步会话缓存 */
+  /** Notify the shared workspace when one summary changes. */
   (e: 'summary-updated', session: ChatSessionItem): void
-  /** 批量生成或重新加载后同步完整会话列表 */
+  /** Sync the full session list after batch generation or reload. */
   (e: 'sessions-updated', sessions: ChatSessionItem[]): void
 }>()
 
diff --git a/src/components/common/ChatRecord/query-session.ts b/src/components/common/ChatRecord/query-session.ts
index bc54ccb1..c35a9dc2 100644
--- a/src/components/common/ChatRecord/query-session.ts
+++ b/src/components/common/ChatRecord/query-session.ts
@@ -13,7 +13,7 @@ export function preserveChatRecordSessionId(
 }
 
 /**
- * 将查询固定到明确的聊天会话，避免页面切换后继续读取上一会话的数据。
+ * Scope a query to the explicit chat session so page changes cannot reuse stale data.
  */
 export function scopeChatRecordQueryToSession(query: ChatRecordQuery, sessionId: string): ChatRecordQuery {
   return { ...query, sessionId }
diff --git a/src/components/common/ChatRecord/workspace-state.test.ts b/src/components/common/ChatRecord/workspace-state.test.ts
new file mode 100644
index 00000000..981c585a
--- /dev/null
+++ b/src/components/common/ChatRecord/workspace-state.test.ts
@@ -0,0 +1,20 @@
+/**
+ * Run: pnpm test -- src/components/common/ChatRecord/workspace-state.test.ts
+ */
+
+import assert from 'node:assert/strict'
+import test from 'node:test'
+import { resolveChatRecordIndexAction, type ChatRecordIndexState } from './workspace-state'
+
+test('only allows index generation after confirming the index is missing', () => {
+  const cases: Array<{ state: ChatRecordIndexState; action: ReturnType<typeof resolveChatRecordIndexAction> }> = [
+    { state: 'loading', action: null },
+    { state: 'ready', action: null },
+    { state: 'missing', action: 'generate' },
+    { state: 'error', action: 'retry' },
+  ]
+
+  for (const { state, action } of cases) {
+    assert.equal(resolveChatRecordIndexAction(state), action, state)
+  }
+})
diff --git a/src/components/common/ChatRecord/workspace-state.ts b/src/components/common/ChatRecord/workspace-state.ts
new file mode 100644
index 00000000..7715f39d
--- /dev/null
+++ b/src/components/common/ChatRecord/workspace-state.ts
@@ -0,0 +1,13 @@
+export type ChatRecordIndexState = 'loading' | 'ready' | 'missing' | 'error'
+
+export type ChatRecordIndexAction = 'generate' | 'retry' | null
+
+/**
+ * Keep destructive index generation exclusive to a confirmed missing state.
+ * Read failures must only offer a retry so existing summaries remain untouched.
+ */
+export function resolveChatRecordIndexAction(state: ChatRecordIndexState): ChatRecordIndexAction {
+  if (state === 'missing') return 'generate'
+  if (state === 'error') return 'retry'
+  return null
+}
diff --git a/src/i18n/locales/en-US/records.json b/src/i18n/locales/en-US/records.json
index 55535df7..3d779114 100644
--- a/src/i18n/locales/en-US/records.json
+++ b/src/i18n/locales/en-US/records.json
@@ -7,7 +7,9 @@
     "indexMissingDescription": "You can still read the original messages. Generate an index to organize summaries into conversation segments; this does not call AI automatically.",
     "generateIndex": "Generate index",
     "indexGenerated": "Generated {count} conversation segments",
-    "indexGenerationFailed": "Failed to generate conversation index"
+    "indexGenerationFailed": "Failed to generate conversation index",
+    "indexLoadFailedTitle": "Failed to load conversation summary index",
+    "indexLoadFailedDescription": "You can still read the original messages. Retry loading; existing summaries will not be changed."
   },
   "messageList": {
     "loading": "Loading...",
diff --git a/src/i18n/locales/ja-JP/records.json b/src/i18n/locales/ja-JP/records.json
index fb244514..3628edd2 100644
--- a/src/i18n/locales/ja-JP/records.json
+++ b/src/i18n/locales/ja-JP/records.json
@@ -7,7 +7,9 @@
     "indexMissingDescription": "元のメッセージはそのまま閲覧できます。インデックスを生成すると要約が会話区間ごとに整理されます。この操作だけでは AI は自動実行されません。",
     "generateIndex": "インデックスを生成",
     "indexGenerated": "{count} 件の会話区間を生成しました",
-    "indexGenerationFailed": "会話インデックスの生成に失敗しました"
+    "indexGenerationFailed": "会話インデックスの生成に失敗しました",
+    "indexLoadFailedTitle": "会話要約インデックスを読み込めませんでした",
+    "indexLoadFailedDescription": "元のメッセージは引き続き閲覧できます。再読み込みしても、既存の要約は変更されません。"
   },
   "messageList": {
     "loading": "読み込み中...",
diff --git a/src/i18n/locales/zh-CN/records.json b/src/i18n/locales/zh-CN/records.json
index ec7494a2..2aab08ea 100644
--- a/src/i18n/locales/zh-CN/records.json
+++ b/src/i18n/locales/zh-CN/records.json
@@ -7,7 +7,9 @@
     "indexMissingDescription": "原始聊天记录仍可直接查看。生成索引后，左侧会按聊天片段组织摘要；此操作不会自动调用 AI。",
     "generateIndex": "生成索引",
     "indexGenerated": "已生成 {count} 个聊天片段",
-    "indexGenerationFailed": "会话索引生成失败"
+    "indexGenerationFailed": "会话索引生成失败",
+    "indexLoadFailedTitle": "会话摘要索引加载失败",
+    "indexLoadFailedDescription": "原始聊天记录仍可查看。请重试加载，现有摘要不会被修改。"
   },
   "messageList": {
     "loading": "加载中...",
diff --git a/src/i18n/locales/zh-TW/records.json b/src/i18n/locales/zh-TW/records.json
index 5eb48c9e..a87cb18d 100644
--- a/src/i18n/locales/zh-TW/records.json
+++ b/src/i18n/locales/zh-TW/records.json
@@ -7,7 +7,9 @@
     "indexMissingDescription": "原始聊天紀錄仍可直接查看。產生索引後，左側會依聊天片段整理摘要；此操作不會自動呼叫 AI。",
     "generateIndex": "產生索引",
     "indexGenerated": "已產生 {count} 個聊天片段",
-    "indexGenerationFailed": "會話索引產生失敗"
+    "indexGenerationFailed": "會話索引產生失敗",
+    "indexLoadFailedTitle": "會話摘要索引載入失敗",
+    "indexLoadFailedDescription": "原始聊天紀錄仍可查看。請重試載入，現有摘要不會被修改。"
   },
   "messageList": {
     "loading": "載入中...",