From 50a08f265c57865d70b6297d5e2ebed5a574aaa3 Mon Sep 17 00:00:00 2001 From: Marcos Lilljedahl Date: Tue, 11 Oct 2016 13:33:22 -0300 Subject: [PATCH] Revert "Don't allocate a pseudo tty for shell attaches" This reverts commit d87e288f6ffa15cf72d8b90567a5cf02e902bf7f. --- services/docker.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/services/docker.go b/services/docker.go index f028b6a..9fd57da 100644 --- a/services/docker.go +++ b/services/docker.go @@ -54,7 +54,7 @@ func DeleteNetwork(id string) error { } func CreateExecConnection(id string, ctx context.Context) (string, error) { - conf := types.ExecConfig{AttachStdin: true, AttachStderr: true, AttachStdout: true, Cmd: []string{"sh"}} + conf := types.ExecConfig{Tty: true, AttachStdin: true, AttachStderr: true, AttachStdout: true, Cmd: []string{"sh"}} resp, err := c.ContainerExecCreate(ctx, id, conf) if err != nil { return "", err @@ -64,7 +64,7 @@ func CreateExecConnection(id string, ctx context.Context) (string, error) { } func AttachExecConnection(execId string, ctx context.Context) (*types.HijackedResponse, error) { - conf := types.ExecConfig{AttachStdin: true, AttachStderr: true, AttachStdout: true} + conf := types.ExecConfig{Tty: true, AttachStdin: true, AttachStderr: true, AttachStdout: true} conn, err := c.ContainerExecAttach(ctx, execId, conf) if err != nil {