study/Spring-Cloud-Alibaba
1
0
Fork 0
mirror of https://gitee.com/mirrors/Spring-Cloud-Alibaba.git synced 2021-06-26 13:25:11 +08:00
Code Issues Releases Wiki Activity

不应该使用类实例访问静态成员\不应该直接使用不确定的值调用equals容易空指针\final static应该使用大写命名并且使用下划线

Browse Source
This commit is contained in:
eden-yuan 2020-12-07 17:17:41 +08:00
parent 569f3f02c1
commit c19bd51584
8 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
spring-cloud-alibaba-examples/rocketmq-example/rocketmq-produce-example/src/main/java/com/alibaba/cloud/examples/RocketMQProduceApplication.java
View File

@ -83,7 +83,7 @@ public class RocketMQProduceApplication {
@Override @Override
public void run(String... args) throws Exception { public void run(String... args) throws Exception {
if (this.bindingName.equals("output1")) { if ("output1".equals(this.bindingName)) {
int count = 5; int count = 5;
for (int index = 1; index <= count; index++) { for (int index = 1; index <= count; index++) {
String msgContent = "msg-" + index; String msgContent = "msg-" + index;
@ -98,7 +98,7 @@ public class RocketMQProduceApplication {
} }
} }
} }
else if (this.bindingName.equals("output3")) { else if ("output3".equals(this.bindingName)) {
int count = 20; int count = 20;
for (int index = 1; index <= count; index++) { for (int index = 1; index <= count; index++) {
String msgContent = "pullMsg-" + index; String msgContent = "pullMsg-" + index;

4
spring-cloud-alibaba-examples/sentinel-example/sentinel-zuul-example/src/main/java/com/alibaba/cloud/examples/ZuulConfiguration.java
View File

@ -41,10 +41,10 @@ public class ZuulConfiguration {
@Override @Override
public BlockResponse fallbackResponse(String route, Throwable cause) { public BlockResponse fallbackResponse(String route, Throwable cause) {
if (route.equals("my-service3")) { if ("my-service3".equals(route)) {
return new BlockResponse(433, "Sentinel Block3", route); return new BlockResponse(433, "Sentinel Block3", route);
} }
else if (route.equals("my-service4")) { else if ("my-service4".equals(route)) {
return new BlockResponse(444, "my-service4", route); return new BlockResponse(444, "my-service4", route);
} }
else { else {

2
spring-cloud-alibaba-starters/spring-cloud-alibaba-sentinel-gateway/src/main/java/com/alibaba/cloud/sentinel/gateway/ConfigConstants.java
View File

@ -37,7 +37,7 @@ public final class ConfigConstants {
/** /**
* ConfigurationProperties for {@link SentinelZuulProperties}. * ConfigurationProperties for {@link SentinelZuulProperties}.
*/ */
public static final String ZUUl_PREFIX = "spring.cloud.sentinel.zuul"; public static final String ZUUL_PREFIX = "spring.cloud.sentinel.zuul";
/** /**
* ConfigurationProperties for {@link SentinelGatewayProperties}. * ConfigurationProperties for {@link SentinelGatewayProperties}.

2
spring-cloud-alibaba-starters/spring-cloud-alibaba-sentinel-gateway/src/main/java/com/alibaba/cloud/sentinel/gateway/zuul/SentinelZuulAutoConfiguration.java
View File

@ -47,7 +47,7 @@ import org.springframework.context.annotation.Configuration;
*/ */
@Configuration(proxyBeanMethods = false) @Configuration(proxyBeanMethods = false)
@ConditionalOnClass(ZuulServlet.class) @ConditionalOnClass(ZuulServlet.class)
@ConditionalOnProperty(prefix = ConfigConstants.ZUUl_PREFIX, name = "enabled", @ConditionalOnProperty(prefix = ConfigConstants.ZUUL_PREFIX, name = "enabled",
havingValue = "true", matchIfMissing = true) havingValue = "true", matchIfMissing = true)
@EnableConfigurationProperties(SentinelZuulProperties.class) @EnableConfigurationProperties(SentinelZuulProperties.class)
public class SentinelZuulAutoConfiguration { public class SentinelZuulAutoConfiguration {

2
spring-cloud-alibaba-starters/spring-cloud-alibaba-sentinel-gateway/src/main/java/com/alibaba/cloud/sentinel/gateway/zuul/SentinelZuulProperties.java
View File

@ -28,7 +28,7 @@ import org.springframework.boot.context.properties.NestedConfigurationProperty;
/** /**
* @author <a href="mailto:fangjian0423@gmail.com">Jim</a> * @author <a href="mailto:fangjian0423@gmail.com">Jim</a>
*/ */
@ConfigurationProperties(prefix = ConfigConstants.ZUUl_PREFIX) @ConfigurationProperties(prefix = ConfigConstants.ZUUL_PREFIX)
public class SentinelZuulProperties { public class SentinelZuulProperties {
@NestedConfigurationProperty @NestedConfigurationProperty

4
spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/main/java/com/alibaba/cloud/nacos/registry/NacosServiceRegistry.java
View File

@ -119,7 +119,7 @@ public class NacosServiceRegistry implements ServiceRegistry<Registration> {
@Override @Override
public void setStatus(Registration registration, String status) { public void setStatus(Registration registration, String status) {
if (!status.equalsIgnoreCase("UP") && !status.equalsIgnoreCase("DOWN")) { if (!"UP".equalsIgnoreCase(status) && !"DOWN".equalsIgnoreCase(status)) {
log.warn("can't support status {},please choose UP or DOWN", status); log.warn("can't support status {},please choose UP or DOWN", status);
return; return;
} }
@ -128,7 +128,7 @@ public class NacosServiceRegistry implements ServiceRegistry<Registration> {
Instance instance = getNacosInstanceFromRegistration(registration); Instance instance = getNacosInstanceFromRegistration(registration);
if (status.equalsIgnoreCase("DOWN")) { if ("DOWN".equalsIgnoreCase(status)) {
instance.setEnabled(false); instance.setEnabled(false);
} }
else { else {

6
spring-cloud-alibaba-starters/spring-cloud-starter-dubbo/src/main/java/com/alibaba/cloud/dubbo/registry/AbstractSpringCloudRegistry.java
View File

@ -77,7 +77,7 @@ public abstract class AbstractSpringCloudRegistry extends FailbackRegistry {
/** /**
* Caches the IDs of {@link ApplicationListener}. * Caches the IDs of {@link ApplicationListener}.
*/ */
private static final Set<String> registerListeners = new HashSet<>(); private static final Set<String> REGISTER_LISTENERS = new HashSet<>();
protected final Logger logger = LoggerFactory.getLogger(getClass()); protected final Logger logger = LoggerFactory.getLogger(getClass());
@ -193,7 +193,7 @@ public abstract class AbstractSpringCloudRegistry extends FailbackRegistry {
private void registerServiceInstancesChangedEventListener(URL url, private void registerServiceInstancesChangedEventListener(URL url,
NotifyListener listener) { NotifyListener listener) {
String listenerId = generateId(url); String listenerId = generateId(url);
if (registerListeners.add(listenerId)) { if (REGISTER_LISTENERS.add(listenerId)) {
applicationContext.addApplicationListener( applicationContext.addApplicationListener(
new ApplicationListener<ServiceInstancesChangedEvent>() { new ApplicationListener<ServiceInstancesChangedEvent>() {
@Override @Override
@ -261,7 +261,7 @@ public abstract class AbstractSpringCloudRegistry extends FailbackRegistry {
String listenerId = generateId(url); String listenerId = generateId(url);
// The metaservice will restart the new listener. It needs to be optimized // The metaservice will restart the new listener. It needs to be optimized
// to see whether the original listener can be reused. // to see whether the original listener can be reused.
this.registerListeners.remove(listenerId); REGISTER_LISTENERS.remove(listenerId);
} }
/** /**

4
spring-cloud-alibaba-starters/spring-cloud-starter-dubbo/src/main/java/com/alibaba/cloud/dubbo/registry/DubboCloudRegistry.java
View File

@ -83,7 +83,7 @@ public class DubboCloudRegistry extends FailbackRegistry {
/** /**
* Caches the IDs of {@link ApplicationListener}. * Caches the IDs of {@link ApplicationListener}.
*/ */
private static final Set<String> registerListeners = new HashSet<>(); private static final Set<String> REGISTER_LISTENERS = new HashSet<>();
protected final Logger logger = LoggerFactory.getLogger(getClass()); protected final Logger logger = LoggerFactory.getLogger(getClass());
@ -215,7 +215,7 @@ public class DubboCloudRegistry extends FailbackRegistry {
private void registerServiceInstancesChangedListener(URL url, private void registerServiceInstancesChangedListener(URL url,
ApplicationListener<ServiceInstancesChangedEvent> listener) { ApplicationListener<ServiceInstancesChangedEvent> listener) {
String listenerId = generateId(url); String listenerId = generateId(url);
if (registerListeners.add(listenerId)) { if (REGISTER_LISTENERS.add(listenerId)) {
applicationContext.addApplicationListener(listener); applicationContext.addApplicationListener(listener);
} }
} }