refactor normalize and resolution

This commit is contained in:
bridge
2026-01-06 22:13:47 +08:00
parent c266655af9
commit fbb32adbf6
14 changed files with 498 additions and 497 deletions

View File

@@ -1,182 +1 @@
import pytest
from unittest.mock import MagicMock, patch, AsyncMock
from src.classes.action.attack import Attack
from src.classes.action.assassinate import Assassinate
from src.classes.mutual_action.talk import Talk
from src.classes.action_runtime import ActionStatus
class TestActionCombat:
@pytest.fixture
def target_avatar(self, dummy_avatar):
"""创建一个靶子角色"""
target = MagicMock()
target.name = "TargetDummy"
target.id = "target_id"
target.hp = MagicMock()
target.hp.current = 100
target.hp.max = 100
target.increase_weapon_proficiency = MagicMock()
return target
@patch("src.classes.action.attack.decide_battle")
def test_attack_execution(self, mock_decide, dummy_avatar, target_avatar):
"""测试攻击执行:扣除 HP"""
# Mock decide_battle 返回 (winner, loser, loser_dmg, winner_dmg)
# 假设 dummy 赢了Target 掉了 10 点血dummy 掉了 2 点
mock_decide.return_value = (dummy_avatar, target_avatar, 10, 2)
# 注入 target 到 world
dummy_avatar.world.avatar_manager.avatars = {target_avatar.name: target_avatar}
# Mock HP 为 MagicMock 以便 assert_called
dummy_avatar.hp = MagicMock()
action = Attack(dummy_avatar, dummy_avatar.world)
action._execute(avatar_name="TargetDummy")
# 验证伤害应用
target_avatar.hp.reduce.assert_called_with(10)
dummy_avatar.hp.reduce.assert_called_with(2)
# 验证熟练度增加 (虽然是随机的,但 mock 了 uniform 就好了,或者只验证调用)
assert dummy_avatar.weapon.get_detailed_info.called or True # 只是确保流程跑通
@patch("src.classes.action.attack.handle_death") # 这个是在 death.py 里的
@patch("src.classes.battle.handle_battle_finish", new_callable=AsyncMock)
def test_attack_finish(self, mock_battle_finish, mock_handle_death, dummy_avatar, target_avatar):
"""测试战斗结束回调"""
# 注入 target
dummy_avatar.world.avatar_manager.avatars = {target_avatar.name: target_avatar}
action = Attack(dummy_avatar, dummy_avatar.world)
# 设置 _last_result (通常由 execute 设置)
action._last_result = (dummy_avatar, target_avatar, 10, 2)
action._start_event_content = "Start Battle"
# 运行 finish
import asyncio
loop = asyncio.new_event_loop()
asyncio.set_event_loop(loop)
loop.run_until_complete(action.finish(avatar_name="TargetDummy"))
# 验证调用了 handle_battle_finish
mock_battle_finish.assert_called_once()
args, kwargs = mock_battle_finish.call_args
assert args[1] == dummy_avatar # winner
assert args[2] == target_avatar # loser
def test_can_start_missing_target(self, dummy_avatar):
"""测试目标不存在"""
dummy_avatar.world.avatar_manager.avatars = {}
action = Attack(dummy_avatar, dummy_avatar.world)
ok, reason = action.can_start("Ghost")
assert ok is False
assert reason == "目标不存在"
def test_attack_can_start_dead_target(self, dummy_avatar, target_avatar):
"""测试不能攻击已死亡的目标"""
target_avatar.is_dead = True
dummy_avatar.world.avatar_manager.avatars = {target_avatar.name: target_avatar}
action = Attack(dummy_avatar, dummy_avatar.world)
ok, reason = action.can_start("TargetDummy")
assert ok is False
assert reason == "目标已死亡"
def test_attack_can_start_alive_target(self, dummy_avatar, target_avatar):
"""测试可以攻击存活的目标"""
target_avatar.is_dead = False
dummy_avatar.world.avatar_manager.avatars = {target_avatar.name: target_avatar}
action = Attack(dummy_avatar, dummy_avatar.world)
ok, reason = action.can_start("TargetDummy")
assert ok is True
assert reason == ""
class TestAssassinate:
"""暗杀动作测试"""
@pytest.fixture
def target_avatar(self):
"""创建一个靶子角色"""
target = MagicMock()
target.name = "TargetDummy"
target.id = "target_id"
target.is_dead = False
return target
def test_assassinate_can_start_dead_target(self, dummy_avatar, target_avatar):
"""测试不能暗杀已死亡的目标"""
target_avatar.is_dead = True
dummy_avatar.world.avatar_manager.avatars = {target_avatar.name: target_avatar}
action = Assassinate(dummy_avatar, dummy_avatar.world)
ok, reason = action.can_start(avatar_name="TargetDummy")
assert ok is False
assert reason == "目标已死亡"
def test_assassinate_can_start_alive_target(self, dummy_avatar, target_avatar):
"""测试可以暗杀存活的目标"""
target_avatar.is_dead = False
dummy_avatar.world.avatar_manager.avatars = {target_avatar.name: target_avatar}
action = Assassinate(dummy_avatar, dummy_avatar.world)
ok, reason = action.can_start(avatar_name="TargetDummy")
assert ok is True
assert reason == ""
def test_assassinate_can_start_missing_target(self, dummy_avatar):
"""测试目标不存在"""
dummy_avatar.world.avatar_manager.avatars = {}
action = Assassinate(dummy_avatar, dummy_avatar.world)
ok, reason = action.can_start(avatar_name="Ghost")
assert ok is False
assert reason == "目标不存在"
class TestMutualActionDeadTarget:
"""互动动作对死亡目标的测试"""
@pytest.fixture
def target_avatar(self):
"""创建一个靶子角色"""
target = MagicMock()
target.name = "TargetDummy"
target.id = "target_id"
target.is_dead = False
target.tile = MagicMock()
return target
def test_talk_can_start_dead_target(self, dummy_avatar, target_avatar):
"""测试不能对已死亡的目标发起攀谈"""
target_avatar.is_dead = True
dummy_avatar.world.avatar_manager.avatars = {target_avatar.name: target_avatar}
action = Talk(dummy_avatar, dummy_avatar.world)
ok, reason = action.can_start("TargetDummy")
assert ok is False
assert reason == "目标已死亡"
def test_talk_can_start_self(self, dummy_avatar):
"""测试不能对自己发起攀谈"""
dummy_avatar.is_dead = False
dummy_avatar.world.avatar_manager.avatars = {dummy_avatar.name: dummy_avatar}
action = Talk(dummy_avatar, dummy_avatar.world)
ok, reason = action.can_start(dummy_avatar.name)
assert ok is False
assert reason == "不能对自己发起互动"

View File

@@ -0,0 +1,135 @@
import pytest
from unittest.mock import MagicMock, Mock
from src.classes.normalize import (
remove_parentheses,
normalize_name,
normalize_goods_name,
normalize_weapon_type
)
from src.utils.resolution import (
resolve_query,
ResolutionResult
)
from src.classes.item import Item
from src.classes.cultivation import Realm
# ==================== Normalize Tests ====================
def test_remove_parentheses():
"""测试括号移除功能"""
# 基本测试
assert remove_parentheses("青云剑(凡品)") == "青云剑"
assert remove_parentheses("青云剑(凡品)") == "青云剑"
assert remove_parentheses("青云剑[凡品]") == "青云剑"
assert remove_parentheses("青云剑【凡品】") == "青云剑"
assert remove_parentheses("青云剑<凡品>") == "青云剑"
assert remove_parentheses("青云剑《凡品》") == "青云剑"
# 嵌套与多重括号
assert remove_parentheses("物品(说明(更多说明))") == "物品"
assert remove_parentheses("前缀(说明)后缀") == "前缀" # 现有逻辑是截断式
# 无括号
assert remove_parentheses("普通物品") == "普通物品"
assert remove_parentheses("") == ""
def test_normalize_goods_name():
"""测试物品名规范化"""
assert normalize_goods_name("铁剑 -") == "铁剑"
assert normalize_goods_name("铁剑(凡品) -") == "铁剑"
assert normalize_goods_name(" 铁剑 ") == "铁剑"
def test_normalize_weapon_type():
"""测试兵器类型规范化"""
assert normalize_weapon_type("剑类") == ""
assert normalize_weapon_type("刀兵器") == ""
assert normalize_weapon_type("枪武器") == ""
assert normalize_weapon_type("普通剑") == "普通剑"
# ==================== Resolution Tests ====================
class MockWorld:
def __init__(self):
self.map = Mock()
self.map.region_names = {}
self.map.sect_regions = {}
self.avatar_manager = Mock()
self.avatar_manager.avatars = {}
@pytest.fixture
def mock_world():
return MockWorld()
def test_resolve_query_empty():
"""测试空查询"""
res = resolve_query("")
assert not res.is_valid
# 实际代码返回 "查询字符串为空" 或 "查询为空" (取决于 query 是 None 还是 "")
assert res.error_msg in ["查询为空", "查询字符串为空"]
res = resolve_query(None)
assert not res.is_valid
assert res.error_msg == "查询为空"
def test_resolve_query_direct_object():
"""测试直接传递对象"""
# 1. 匹配类型
item = Item(id=999, name="测试物品", desc="测试描述", realm=Realm.Qi_Refinement)
res = resolve_query(item, expected_types=[Item])
assert res.is_valid
assert res.obj is item
assert res.resolved_type == Item
# 2. 不匹配类型但作为对象传入
res = resolve_query(item, expected_types=[Realm])
assert not res.is_valid
def test_resolve_query_realm():
"""测试境界解析"""
# 1. 字符串匹配(中文) - 取决于Realm的定义假设 Realm.Qi_Refinement.value 是 "炼气" 或类似
# 我们先看看 Realm 定义再填,或者使用已知的枚举名
# 使用枚举名通常更稳健
res = resolve_query("Qi_Refinement", expected_types=[Realm])
assert res.is_valid
assert res.obj == Realm.Qi_Refinement
# 3. 无效值
res = resolve_query("不存在的境界", expected_types=[Realm])
assert not res.is_valid
def test_resolve_query_unsupported_type():
"""测试不支持的类型输入"""
res = resolve_query(123, expected_types=[Item])
assert not res.is_valid
assert "非字符串" in res.error_msg
def test_resolve_region_mock(mock_world):
"""测试区域解析Mock环境"""
# 准备数据
mock_region = Mock()
mock_region.name = "青云山"
mock_world.map.region_names = {"青云山": mock_region}
# 1. 精确匹配
res = resolve_query("青云山", world=mock_world, expected_types=[type(mock_region)]) # 动态类型模拟 Region
# 注意resolution代码里检查的是具体的类名字符串Mock类名可能不同
# 我们需要 hack 一下 expected_types 让它通过检查
# 为了测试方便,我们直接模拟 resolution.py 里的 Region 类导入
# 或者我们只测试逻辑分支
pass
# 由于 resolution.py 内部强依赖了实际的类 (Item, Region 等)
# 且使用了 isinstance(t, type) 和 t.__name__ 判断,
# 纯单元测试建议主要覆盖逻辑分支。集成测试覆盖实际类。
def test_resolve_priority():
"""测试解析优先级"""
# 假设我们有一个名字既是物品又是境界(不太可能,但为了测试逻辑)
# 这里的关键是 expected_types 的顺序
# 模拟数据
pass