Compare commits

..

1 Commits

Author SHA1 Message Date
YoVinchen b6bacd6b4a Stop sending prompt cache keys on Claude chat conversions
Responses conversions still use promptCacheKey, but chat completions now stay a pure shape transform. This keeps Claude -> chat requests aligned with providers that do not understand the field and keeps stream checks consistent with production behavior.

Constraint: Issue #1919 requires removing prompt_cache_key from Claude -> OpenAI Chat requests
Rejected: Add a runtime toggle for chat injection | requested behavior is unconditional removal
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: Keep promptCacheKey limited to Claude -> Responses conversions unless a provider-specific contract is proven
Tested: cargo test anthropic_to_openai
Tested: cargo test anthropic_to_responses_with_cache_key
Tested: cargo test transform_claude_request_for_api_format_responses
Not-tested: Full src-tauri test suite
Related: #1919
2026-04-11 16:46:41 +08:00
19 changed files with 88 additions and 1015 deletions
-5
View File
@@ -11,11 +11,6 @@
"updater:default",
"core:window:allow-set-skip-taskbar",
"core:window:allow-start-dragging",
"core:window:allow-minimize",
"core:window:allow-toggle-maximize",
"core:window:allow-is-maximized",
"core:window:allow-close",
"core:window:allow-set-decorations",
"process:allow-restart",
"dialog:default"
]
+11 -14
View File
@@ -86,7 +86,10 @@ pub async fn update_global_proxy_config(
state: tauri::State<'_, AppState>,
config: GlobalProxyConfig,
) -> Result<(), String> {
state.proxy_service.update_global_proxy_config(config).await
let db = &state.db;
db.update_global_proxy_config(config)
.await
.map_err(|e| e.to_string())
}
/// 获取指定应用的代理配置
@@ -111,10 +114,10 @@ pub async fn update_proxy_config_for_app(
state: tauri::State<'_, AppState>,
config: AppProxyConfig,
) -> Result<(), String> {
state
.proxy_service
.update_proxy_config_for_app(config)
let db = &state.db;
db.update_proxy_config_for_app(config)
.await
.map_err(|e| e.to_string())
}
async fn get_default_cost_multiplier_internal(
@@ -149,11 +152,8 @@ async fn set_default_cost_multiplier_internal(
app_type: &str,
value: &str,
) -> Result<(), AppError> {
state
.proxy_service
.set_default_cost_multiplier(app_type, value)
.await
.map_err(AppError::Config)
let db = &state.db;
db.set_default_cost_multiplier(app_type, value).await
}
#[cfg_attr(not(feature = "test-hooks"), doc(hidden))]
@@ -209,11 +209,8 @@ async fn set_pricing_model_source_internal(
app_type: &str,
value: &str,
) -> Result<(), AppError> {
state
.proxy_service
.set_pricing_model_source(app_type, value)
.await
.map_err(AppError::Config)
let db = &state.db;
db.set_pricing_model_source(app_type, value).await
}
#[cfg_attr(not(feature = "test-hooks"), doc(hidden))]
+1 -7
View File
@@ -115,17 +115,11 @@ pub async fn webdav_sync_upload(state: State<'_, AppState>) -> Result<Value, Str
#[tauri::command]
pub async fn webdav_sync_download(state: State<'_, AppState>) -> Result<Value, String> {
let db = state.db.clone();
let proxy_service = state.proxy_service.clone();
let db_for_sync = db.clone();
let mut settings = require_enabled_webdav_settings()?;
let _auto_sync_suppression = crate::services::webdav_auto_sync::AutoSyncSuppressionGuard::new();
let sync_result = run_with_webdav_lock(webdav_sync_service::download(
&db,
&proxy_service,
&mut settings,
))
.await;
let sync_result = run_with_webdav_lock(webdav_sync_service::download(&db, &mut settings)).await;
let mut result = map_sync_result(sync_result, |error| {
persist_sync_error(&mut settings, error, "manual")
})?;
+24 -369
View File
@@ -7,7 +7,7 @@ use crate::config::get_app_config_dir;
use crate::error::AppError;
use chrono::{Local, Utc};
use rusqlite::backup::Backup;
use rusqlite::types::Value;
use rusqlite::types::ValueRef;
use rusqlite::Connection;
use std::fs;
use std::path::{Path, PathBuf};
@@ -33,64 +33,6 @@ const SYNC_PRESERVE_TABLES: &[&str] = &[
"usage_daily_rollups",
];
const PROXY_CONFIG_LOCAL_COLUMNS: &[&str] =
&["proxy_enabled", "listen_address", "listen_port", "enabled"];
#[derive(Clone, Copy)]
enum SyncNeutralValue {
Integer(i64),
Text(&'static str),
}
impl SyncNeutralValue {
fn into_sql_value(self) -> Value {
match self {
Self::Integer(value) => Value::Integer(value),
Self::Text(value) => Value::Text(value.to_string()),
}
}
}
#[derive(Clone, Copy)]
struct SyncNeutralizedColumn {
column: &'static str,
value: SyncNeutralValue,
}
#[derive(Clone, Copy)]
struct SyncRowTransform {
table: &'static str,
key_column: &'static str,
local_columns: &'static [&'static str],
export_defaults: &'static [SyncNeutralizedColumn],
}
const PROXY_CONFIG_EXPORT_DEFAULTS: &[SyncNeutralizedColumn] = &[
SyncNeutralizedColumn {
column: "proxy_enabled",
value: SyncNeutralValue::Integer(0),
},
SyncNeutralizedColumn {
column: "listen_address",
value: SyncNeutralValue::Text("127.0.0.1"),
},
SyncNeutralizedColumn {
column: "listen_port",
value: SyncNeutralValue::Integer(15721),
},
SyncNeutralizedColumn {
column: "enabled",
value: SyncNeutralValue::Integer(0),
},
];
const SYNC_ROW_TRANSFORMS: &[SyncRowTransform] = &[SyncRowTransform {
table: "proxy_config",
key_column: "app_type",
local_columns: PROXY_CONFIG_LOCAL_COLUMNS,
export_defaults: PROXY_CONFIG_EXPORT_DEFAULTS,
}];
/// A database backup entry for the UI
#[derive(Debug, serde::Serialize)]
#[serde(rename_all = "camelCase")]
@@ -104,13 +46,13 @@ impl Database {
/// 导出为 SQLite 兼容的 SQL 文本(内存字符串,完整导出)
pub fn export_sql_string(&self) -> Result<String, AppError> {
let snapshot = self.snapshot_to_memory()?;
Self::dump_sql(&snapshot, &[], &[])
Self::dump_sql(&snapshot, &[])
}
/// Export SQL for sync (WebDAV), skipping local-only tables' data
pub fn export_sql_string_for_sync(&self) -> Result<String, AppError> {
let snapshot = self.snapshot_to_memory()?;
Self::dump_sql(&snapshot, SYNC_SKIP_TABLES, SYNC_ROW_TRANSFORMS)
Self::dump_sql(&snapshot, SYNC_SKIP_TABLES)
}
/// 导出为 SQLite 兼容的 SQL 文本
@@ -140,20 +82,19 @@ impl Database {
/// 从 SQL 字符串导入,返回生成的备份 ID(若无备份则为空字符串)
pub fn import_sql_string(&self, sql_raw: &str) -> Result<String, AppError> {
self.import_sql_string_inner(sql_raw, &[], &[])
self.import_sql_string_inner(sql_raw, &[])
}
/// Import SQL generated for sync, then restore local-only tables from the
/// current device snapshot before replacing the main database.
pub(crate) fn import_sql_string_for_sync(&self, sql_raw: &str) -> Result<String, AppError> {
self.import_sql_string_inner(sql_raw, SYNC_PRESERVE_TABLES, SYNC_ROW_TRANSFORMS)
self.import_sql_string_inner(sql_raw, SYNC_PRESERVE_TABLES)
}
fn import_sql_string_inner(
&self,
sql_raw: &str,
preserve_tables: &[&str],
row_transforms: &[SyncRowTransform],
) -> Result<String, AppError> {
let sql_content = sql_raw.trim_start_matches('\u{feff}');
Self::validate_cc_switch_sql_export(sql_content)?;
@@ -161,7 +102,7 @@ impl Database {
// 导入前备份现有数据库
let backup_path = self.backup_database_file()?;
let local_snapshot = if preserve_tables.is_empty() && row_transforms.is_empty() {
let local_snapshot = if preserve_tables.is_empty() {
None
} else {
Some(self.snapshot_to_memory()?)
@@ -186,7 +127,6 @@ impl Database {
Self::validate_basic_state(&temp_conn)?;
if let Some(local_snapshot) = local_snapshot.as_ref() {
Self::restore_tables(local_snapshot, &temp_conn, preserve_tables)?;
Self::restore_row_transforms(local_snapshot, &temp_conn, row_transforms)?;
}
// 使用 Backup 将临时库原子写回主库
@@ -292,111 +232,6 @@ impl Database {
Ok(())
}
fn restore_row_transforms(
source_conn: &Connection,
target_conn: &Connection,
transforms: &[SyncRowTransform],
) -> Result<(), AppError> {
for transform in transforms {
Self::restore_row_transform(source_conn, target_conn, transform)?;
}
Ok(())
}
fn restore_row_transform(
source_conn: &Connection,
target_conn: &Connection,
transform: &SyncRowTransform,
) -> Result<(), AppError> {
if !Self::table_exists(source_conn, transform.table)?
|| !Self::table_exists(target_conn, transform.table)?
{
return Ok(());
}
let source_columns = Self::get_table_columns(source_conn, transform.table)?;
let target_columns = Self::get_table_columns(target_conn, transform.table)?;
if !source_columns
.iter()
.any(|column| column == transform.key_column)
|| !target_columns
.iter()
.any(|column| column == transform.key_column)
{
return Ok(());
}
let local_columns = transform
.local_columns
.iter()
.copied()
.filter(|column| {
source_columns.iter().any(|existing| existing == column)
&& target_columns.iter().any(|existing| existing == column)
})
.collect::<Vec<_>>();
if local_columns.is_empty() {
return Ok(());
}
let select_columns = std::iter::once(transform.key_column)
.chain(local_columns.iter().copied())
.map(Self::quote_ident)
.collect::<Vec<_>>()
.join(", ");
let select_sql = format!(
"SELECT {select_columns} FROM {}",
Self::quote_ident(transform.table)
);
let assignments = local_columns
.iter()
.enumerate()
.map(|(idx, column)| format!("{} = ?{}", Self::quote_ident(column), idx + 1))
.collect::<Vec<_>>()
.join(", ");
let update_sql = format!(
"UPDATE {} SET {assignments} WHERE {} = ?{}",
Self::quote_ident(transform.table),
Self::quote_ident(transform.key_column),
local_columns.len() + 1
);
let mut stmt = source_conn.prepare(&select_sql).map_err(|e| {
AppError::Database(format!(
"读取本地表 {} 的同步字段失败: {e}",
transform.table
))
})?;
let mut rows = stmt.query([]).map_err(|e| {
AppError::Database(format!("查询本地表 {} 数据失败: {e}", transform.table))
})?;
while let Some(row) = rows.next().map_err(|e| AppError::Database(e.to_string()))? {
let mut values = Vec::with_capacity(local_columns.len() + 1);
for idx in 1..=local_columns.len() {
values.push(
row.get::<_, Value>(idx)
.map_err(|e| AppError::Database(e.to_string()))?,
);
}
values.push(
row.get::<_, Value>(0)
.map_err(|e| AppError::Database(e.to_string()))?,
);
target_conn
.execute(&update_sql, rusqlite::params_from_iter(values.iter()))
.map_err(|e| {
AppError::Database(format!(
"恢复本地表 {} 的同步字段失败: {e}",
transform.table
))
})?;
}
Ok(())
}
/// Periodic backup: create a new backup if the latest one is older than the configured interval
pub(crate) fn periodic_backup_if_needed(&self) -> Result<(), AppError> {
let interval_hours = crate::settings::effective_backup_interval_hours();
@@ -549,11 +384,7 @@ impl Database {
}
/// 导出数据库为 SQL 文本
fn dump_sql(
conn: &Connection,
skip_tables: &[&str],
row_transforms: &[SyncRowTransform],
) -> Result<String, AppError> {
fn dump_sql(conn: &Connection, skip_tables: &[&str]) -> Result<String, AppError> {
let mut output = String::new();
let timestamp = Utc::now().format("%Y-%m-%d %H:%M:%S").to_string();
let user_version: i64 = conn
@@ -619,14 +450,10 @@ impl Database {
while let Some(row) = rows.next().map_err(|e| AppError::Database(e.to_string()))? {
let mut values = Vec::with_capacity(columns.len());
for idx in 0..columns.len() {
values.push(
row.get::<_, Value>(idx)
.map_err(|e| AppError::Database(e.to_string()))?,
);
}
if let Some(transform) = row_transforms.iter().find(|t| t.table == table) {
Self::apply_export_defaults(&columns, &mut values, transform);
let value = row
.get_ref(idx)
.map_err(|e| AppError::Database(e.to_string()))?;
values.push(Self::format_sql_value(value)?);
}
let cols = columns
@@ -636,11 +463,7 @@ impl Database {
.join(", ");
output.push_str(&format!(
"INSERT INTO \"{table}\" ({cols}) VALUES ({});\n",
values
.iter()
.map(Self::format_owned_sql_value)
.collect::<Result<Vec<_>, _>>()?
.join(", ")
values.join(", ")
));
}
}
@@ -665,13 +488,19 @@ impl Database {
Ok(columns)
}
fn format_owned_sql_value(value: &Value) -> Result<String, AppError> {
/// 格式化 SQL 值
fn format_sql_value(value: ValueRef<'_>) -> Result<String, AppError> {
match value {
Value::Null => Ok("NULL".to_string()),
Value::Integer(i) => Ok(i.to_string()),
Value::Real(f) => Ok(f.to_string()),
Value::Text(text) => Ok(format!("'{}'", text.replace('\'', "''"))),
Value::Blob(bytes) => {
ValueRef::Null => Ok("NULL".to_string()),
ValueRef::Integer(i) => Ok(i.to_string()),
ValueRef::Real(f) => Ok(f.to_string()),
ValueRef::Text(t) => {
let text = std::str::from_utf8(t)
.map_err(|e| AppError::Database(format!("文本字段不是有效的 UTF-8: {e}")))?;
let escaped = text.replace('\'', "''");
Ok(format!("'{escaped}'"))
}
ValueRef::Blob(bytes) => {
let mut s = String::from("X'");
for b in bytes {
use std::fmt::Write;
@@ -683,22 +512,6 @@ impl Database {
}
}
fn apply_export_defaults(
columns: &[String],
values: &mut [Value],
transform: &SyncRowTransform,
) {
for default in transform.export_defaults {
if let Some(idx) = columns.iter().position(|column| column == default.column) {
values[idx] = default.value.into_sql_value();
}
}
}
fn quote_ident(value: &str) -> String {
format!("\"{}\"", value.replace('"', "\"\""))
}
/// List all database backup files, sorted by creation time (newest first)
pub fn list_backups() -> Result<Vec<BackupEntry>, AppError> {
let backup_dir = get_app_config_dir().join("backups");
@@ -879,75 +692,8 @@ mod tests {
use super::Database;
use crate::error::AppError;
use crate::settings::{update_settings, AppSettings};
use rusqlite::Connection;
use serial_test::serial;
fn seed_provider(conn: &Connection, id: &str) -> Result<(), AppError> {
conn.execute(
"INSERT INTO providers (id, app_type, name, settings_config, meta)
VALUES (?1, 'claude', ?2, '{}', '{}')",
rusqlite::params![id, format!("Provider {id}")],
)
.map_err(|e| AppError::Database(e.to_string()))?;
Ok(())
}
#[allow(clippy::too_many_arguments)]
fn set_proxy_row(
conn: &Connection,
app_type: &str,
proxy_enabled: bool,
listen_address: &str,
listen_port: i64,
enabled: bool,
auto_failover_enabled: bool,
max_retries: i64,
) -> Result<(), AppError> {
conn.execute(
"UPDATE proxy_config
SET proxy_enabled = ?2,
listen_address = ?3,
listen_port = ?4,
enabled = ?5,
auto_failover_enabled = ?6,
max_retries = ?7
WHERE app_type = ?1",
rusqlite::params![
app_type,
if proxy_enabled { 1 } else { 0 },
listen_address,
listen_port,
if enabled { 1 } else { 0 },
if auto_failover_enabled { 1 } else { 0 },
max_retries,
],
)
.map_err(|e| AppError::Database(e.to_string()))?;
Ok(())
}
fn read_proxy_row(
conn: &Connection,
app_type: &str,
) -> Result<(bool, String, i64, bool, bool, i64), AppError> {
conn.query_row(
"SELECT proxy_enabled, listen_address, listen_port, enabled, auto_failover_enabled, max_retries
FROM proxy_config WHERE app_type = ?1",
[app_type],
|row| {
Ok((
row.get::<_, i64>(0)? != 0,
row.get(1)?,
row.get(2)?,
row.get::<_, i64>(3)? != 0,
row.get::<_, i64>(4)? != 0,
row.get(5)?,
))
},
)
.map_err(|e| AppError::Database(e.to_string()))
}
#[test]
fn sync_import_preserves_local_only_tables() -> Result<(), AppError> {
let remote_db = Database::memory()?;
@@ -1035,97 +781,6 @@ mod tests {
Ok(())
}
#[test]
fn sync_import_preserves_local_proxy_config_local_fields() -> Result<(), AppError> {
let remote_db = Database::memory()?;
{
let conn = crate::database::lock_conn!(remote_db.conn);
seed_provider(&conn, "remote-provider")?;
set_proxy_row(
&conn,
"claude",
false,
"192.168.10.10",
31001,
false,
true,
9,
)?;
set_proxy_row(&conn, "codex", true, "192.168.10.11", 31002, true, false, 8)?;
set_proxy_row(
&conn,
"gemini",
false,
"192.168.10.12",
31003,
true,
true,
7,
)?;
}
let remote_sql = remote_db.export_sql_string()?;
let local_db = Database::memory()?;
{
let conn = crate::database::lock_conn!(local_db.conn);
seed_provider(&conn, "local-provider")?;
set_proxy_row(&conn, "claude", true, "10.0.0.1", 21001, true, false, 1)?;
set_proxy_row(&conn, "codex", false, "10.0.0.2", 21002, false, true, 2)?;
set_proxy_row(&conn, "gemini", true, "10.0.0.3", 21003, false, false, 3)?;
}
local_db.import_sql_string_for_sync(&remote_sql)?;
let conn = crate::database::lock_conn!(local_db.conn);
assert_eq!(
read_proxy_row(&conn, "claude")?,
(true, "10.0.0.1".to_string(), 21001, true, true, 9)
);
assert_eq!(
read_proxy_row(&conn, "codex")?,
(false, "10.0.0.2".to_string(), 21002, false, false, 8)
);
assert_eq!(
read_proxy_row(&conn, "gemini")?,
(true, "10.0.0.3".to_string(), 21003, false, true, 7)
);
Ok(())
}
#[test]
fn sync_export_scrubs_proxy_config_local_fields_but_keeps_strategy_fields(
) -> Result<(), AppError> {
let db = Database::memory()?;
{
let conn = crate::database::lock_conn!(db.conn);
seed_provider(&conn, "portable-provider")?;
set_proxy_row(&conn, "claude", true, "10.1.0.1", 41001, true, true, 6)?;
set_proxy_row(&conn, "codex", true, "10.1.0.2", 41002, true, false, 5)?;
set_proxy_row(&conn, "gemini", true, "10.1.0.3", 41003, true, true, 4)?;
}
let sync_sql = db.export_sql_string_for_sync()?;
let old_client_db = Database::memory()?;
old_client_db.import_sql_string(&sync_sql)?;
let conn = crate::database::lock_conn!(old_client_db.conn);
assert_eq!(
read_proxy_row(&conn, "claude")?,
(false, "127.0.0.1".to_string(), 15721, false, true, 6)
);
assert_eq!(
read_proxy_row(&conn, "codex")?,
(false, "127.0.0.1".to_string(), 15721, false, false, 5)
);
assert_eq!(
read_proxy_row(&conn, "gemini")?,
(false, "127.0.0.1".to_string(), 15721, false, true, 4)
);
Ok(())
}
#[test]
#[serial]
fn periodic_maintenance_runs_even_when_auto_backup_disabled() -> Result<(), AppError> {
-4
View File
@@ -971,10 +971,6 @@ pub fn run() {
// 静默启动:根据设置决定是否显示主窗口
let settings = crate::settings::get_settings();
if let Some(window) = app.get_webview_window("main") {
// 在窗口首次显示前同步装饰状态,避免前端加载后再切换导致标题栏闪烁
// 仅 Linux 生效:解决 Wayland 下系统窗口按钮不可用的问题
#[cfg(target_os = "linux")]
let _ = window.set_decorations(!settings.use_app_window_controls);
if settings.silent_startup {
// 静默启动模式:保持窗口隐藏
let _ = window.hide();
+3 -3
View File
@@ -282,9 +282,9 @@ pub struct ProviderMeta {
/// 是否将 base_url 视为完整 API 端点(不拼接 endpoint 路径)
#[serde(rename = "isFullUrl", skip_serializing_if = "Option::is_none")]
pub is_full_url: Option<bool>,
/// Prompt cache key for OpenAI-compatible endpoints.
/// When set, injected into converted requests to improve cache hit rate.
/// If not set, provider ID is used automatically during format conversion.
/// Prompt cache key for OpenAI Responses-compatible endpoints.
/// When set, injected into converted Responses requests to improve cache hit rate.
/// If not set, provider ID is used automatically during Claude -> Responses conversion.
#[serde(rename = "promptCacheKey", skip_serializing_if = "Option::is_none")]
pub prompt_cache_key: Option<String>,
/// 累加模式应用中,该 provider 是否已写入 live config。
+6 -7
View File
@@ -81,14 +81,13 @@ pub fn transform_claude_request_for_api_format(
provider: &Provider,
api_format: &str,
) -> Result<serde_json::Value, ProxyError> {
let cache_key = provider
.meta
.as_ref()
.and_then(|m| m.prompt_cache_key.as_deref())
.unwrap_or(&provider.id);
match api_format {
"openai_responses" => {
let cache_key = provider
.meta
.as_ref()
.and_then(|m| m.prompt_cache_key.as_deref())
.unwrap_or(&provider.id);
// Codex OAuth (ChatGPT Plus/Pro 反代) 需要在请求体里强制 store: false
// + include: ["reasoning.encrypted_content"],由 transform 层统一处理。
let is_codex_oauth = provider
@@ -102,7 +101,7 @@ pub fn transform_claude_request_for_api_format(
is_codex_oauth,
)
}
"openai_chat" => super::transform::anthropic_to_openai(body, Some(cache_key)),
"openai_chat" => super::transform::anthropic_to_openai(body),
_ => Ok(body),
}
}
+20 -39
View File
@@ -71,10 +71,8 @@ pub fn resolve_reasoning_effort(body: &Value) -> Option<&'static str> {
}
}
/// Anthropic 请求 → OpenAI 请求
///
/// `cache_key`: optional prompt_cache_key to inject for improved cache routing
pub fn anthropic_to_openai(body: Value, cache_key: Option<&str>) -> Result<Value, ProxyError> {
/// Anthropic 请求 → OpenAI Chat Completions 请求
pub fn anthropic_to_openai(body: Value) -> Result<Value, ProxyError> {
let mut result = json!({});
// NOTE: 模型映射由上游统一处理(proxy::model_mapper),格式转换层只做结构转换。
@@ -175,11 +173,6 @@ pub fn anthropic_to_openai(body: Value, cache_key: Option<&str>) -> Result<Value
result["tool_choice"] = v.clone();
}
// Inject prompt_cache_key for improved cache routing on OpenAI-compatible endpoints
if let Some(key) = cache_key {
result["prompt_cache_key"] = json!(key);
}
Ok(result)
}
@@ -569,7 +562,7 @@ mod tests {
"messages": [{"role": "user", "content": "Hello"}]
});
let result = anthropic_to_openai(input, None).unwrap();
let result = anthropic_to_openai(input).unwrap();
assert_eq!(result["model"], "claude-3-opus");
assert_eq!(result["max_tokens"], 1024);
assert_eq!(result["messages"][0]["role"], "user");
@@ -585,7 +578,7 @@ mod tests {
"messages": [{"role": "user", "content": "Hello"}]
});
let result = anthropic_to_openai(input, None).unwrap();
let result = anthropic_to_openai(input).unwrap();
assert_eq!(result["messages"][0]["role"], "system");
assert_eq!(
result["messages"][0]["content"],
@@ -607,7 +600,7 @@ mod tests {
}]
});
let result = anthropic_to_openai(input, None).unwrap();
let result = anthropic_to_openai(input).unwrap();
assert_eq!(result["tools"][0]["type"], "function");
assert_eq!(result["tools"][0]["function"]["name"], "get_weather");
}
@@ -627,7 +620,7 @@ mod tests {
]
});
let result = anthropic_to_openai(input, None).unwrap();
let result = anthropic_to_openai(input).unwrap();
assert_eq!(result["messages"].as_array().unwrap().len(), 2);
assert_eq!(result["messages"][0]["role"], "system");
assert_eq!(
@@ -651,7 +644,7 @@ mod tests {
}]
});
let result = anthropic_to_openai(input, None).unwrap();
let result = anthropic_to_openai(input).unwrap();
let msg = &result["messages"][0];
assert_eq!(msg["role"], "assistant");
assert!(msg.get("tool_calls").is_some());
@@ -671,7 +664,7 @@ mod tests {
}]
});
let result = anthropic_to_openai(input, None).unwrap();
let result = anthropic_to_openai(input).unwrap();
let msg = &result["messages"][0];
assert_eq!(msg["role"], "tool");
assert_eq!(msg["tool_call_id"], "call_123");
@@ -743,31 +736,19 @@ mod tests {
"messages": [{"role": "user", "content": "Hello"}]
});
let result = anthropic_to_openai(input, None).unwrap();
let result = anthropic_to_openai(input).unwrap();
assert_eq!(result["model"], "gpt-4o");
}
#[test]
fn test_anthropic_to_openai_with_cache_key() {
fn test_anthropic_to_openai_does_not_inject_prompt_cache_key() {
let input = json!({
"model": "claude-3-opus",
"max_tokens": 1024,
"messages": [{"role": "user", "content": "Hello"}]
});
let result = anthropic_to_openai(input, Some("provider-123")).unwrap();
assert_eq!(result["prompt_cache_key"], "provider-123");
}
#[test]
fn test_anthropic_to_openai_no_cache_key() {
let input = json!({
"model": "claude-3-opus",
"max_tokens": 1024,
"messages": [{"role": "user", "content": "Hello"}]
});
let result = anthropic_to_openai(input, None).unwrap();
let result = anthropic_to_openai(input).unwrap();
assert!(result.get("prompt_cache_key").is_none());
}
@@ -793,7 +774,7 @@ mod tests {
}]
});
let result = anthropic_to_openai(input, None).unwrap();
let result = anthropic_to_openai(input).unwrap();
// System message cache_control preserved
assert_eq!(result["messages"][0]["cache_control"]["type"], "ephemeral");
// Text block cache_control preserved
@@ -1047,7 +1028,7 @@ mod tests {
"messages": [{"role": "user", "content": "Hello"}]
});
let result = anthropic_to_openai(input, None).unwrap();
let result = anthropic_to_openai(input).unwrap();
assert!(result.get("reasoning_effort").is_none());
}
@@ -1060,7 +1041,7 @@ mod tests {
"messages": [{"role": "user", "content": "Hello"}]
});
let result = anthropic_to_openai(input, None).unwrap();
let result = anthropic_to_openai(input).unwrap();
assert_eq!(result["reasoning_effort"], "medium");
}
@@ -1073,7 +1054,7 @@ mod tests {
"messages": [{"role": "user", "content": "Hello"}]
});
let result = anthropic_to_openai(input, None).unwrap();
let result = anthropic_to_openai(input).unwrap();
assert_eq!(result["reasoning_effort"], "xhigh");
}
@@ -1086,7 +1067,7 @@ mod tests {
"messages": [{"role": "user", "content": "Hello"}]
});
let result = anthropic_to_openai(input, None).unwrap();
let result = anthropic_to_openai(input).unwrap();
assert_eq!(result["reasoning_effort"], "low");
}
@@ -1099,7 +1080,7 @@ mod tests {
"messages": [{"role": "user", "content": "Hello"}]
});
let result = anthropic_to_openai(input, None).unwrap();
let result = anthropic_to_openai(input).unwrap();
assert_eq!(result["reasoning_effort"], "xhigh");
}
@@ -1111,7 +1092,7 @@ mod tests {
"messages": [{"role": "user", "content": "Hello"}]
});
let result = anthropic_to_openai(input, None).unwrap();
let result = anthropic_to_openai(input).unwrap();
assert!(result.get("reasoning_effort").is_none());
}
@@ -1124,7 +1105,7 @@ mod tests {
"messages": [{"role": "user", "content": "Hello"}]
});
let result = anthropic_to_openai(input, None).unwrap();
let result = anthropic_to_openai(input).unwrap();
assert!(
result.get("max_tokens").is_none(),
"{model} should not have max_tokens"
@@ -1144,7 +1125,7 @@ mod tests {
"messages": [{"role": "user", "content": "Hello"}]
});
let result = anthropic_to_openai(input, None).unwrap();
let result = anthropic_to_openai(input).unwrap();
assert_eq!(result["max_tokens"], 1024);
assert!(result.get("max_completion_tokens").is_none());
}
+7 -297
View File
@@ -14,8 +14,8 @@ use crate::services::provider::{
};
use serde_json::{json, Value};
use std::str::FromStr;
use std::sync::{Arc, OnceLock};
use tokio::sync::{Mutex, RwLock};
use std::sync::Arc;
use tokio::sync::RwLock;
/// 用于接管 Live 配置时的占位符(避免客户端提示缺少 key,同时不泄露真实 Token)
const PROXY_TOKEN_PLACEHOLDER: &str = "PROXY_MANAGED";
@@ -34,11 +34,6 @@ const CLAUDE_MODEL_OVERRIDE_ENV_KEYS: [&str; 6] = [
"ANTHROPIC_SMALL_FAST_MODEL",
];
pub(crate) fn restore_mutation_guard() -> &'static Mutex<()> {
static LOCK: OnceLock<Mutex<()>> = OnceLock::new();
LOCK.get_or_init(|| Mutex::new(()))
}
#[derive(Clone)]
pub struct ProxyService {
db: Arc<Database>,
@@ -159,11 +154,6 @@ impl ProxyService {
/// 启动代理服务器
pub async fn start(&self) -> Result<ProxyServerInfo, String> {
let _guard = restore_mutation_guard().lock().await;
self.start_unlocked().await
}
async fn start_unlocked(&self) -> Result<ProxyServerInfo, String> {
// 1. 启动时自动设置 proxy_enabled = true
let mut global_config = self
.db
@@ -214,8 +204,6 @@ impl ProxyService {
/// 启动代理服务器(带 Live 配置接管)
pub async fn start_with_takeover(&self) -> Result<ProxyServerInfo, String> {
let _guard = restore_mutation_guard().lock().await;
// 1. 备份各应用的 Live 配置
self.backup_live_configs().await?;
@@ -254,7 +242,7 @@ impl ProxyService {
}
// 5. 启动代理服务器
match self.start_unlocked().await {
match self.start().await {
Ok(info) => Ok(info),
Err(e) => {
// 启动失败,恢复原始配置
@@ -312,22 +300,13 @@ impl ProxyService {
/// - 开启:自动启动代理服务,仅接管当前 app 的 Live 配置
/// - 关闭:仅恢复当前 app 的 Live 配置;若无其它接管,则自动停止代理服务
pub async fn set_takeover_for_app(&self, app_type: &str, enabled: bool) -> Result<(), String> {
let _guard = restore_mutation_guard().lock().await;
self.set_takeover_for_app_unlocked(app_type, enabled).await
}
async fn set_takeover_for_app_unlocked(
&self,
app_type: &str,
enabled: bool,
) -> Result<(), String> {
let app = AppType::from_str(app_type).map_err(|e| format!("无效的应用类型: {e}"))?;
let app_type_str = app.as_str();
if enabled {
// 1) 代理服务未运行则自动启动
if !self.is_running().await {
self.start_unlocked().await?;
self.start().await?;
}
// 2) 已接管则直接返回(幂等);但如果缺少备份或占位符残留,需要重建接管
@@ -450,7 +429,7 @@ impl ProxyService {
if self.is_running().await {
// 此时没有任何 app 处于接管状态,停止服务即可
let _ = self.stop_unlocked().await;
let _ = self.stop().await;
}
}
@@ -720,11 +699,6 @@ impl ProxyService {
/// 停止代理服务器
pub async fn stop(&self) -> Result<(), String> {
let _guard = restore_mutation_guard().lock().await;
self.stop_unlocked().await
}
async fn stop_unlocked(&self) -> Result<(), String> {
if let Some(server) = self.server.write().await.take() {
server
.stop()
@@ -756,9 +730,8 @@ impl ProxyService {
///
/// 会清除 settings 表中的代理状态,下次启动不会自动恢复。
pub async fn stop_with_restore(&self) -> Result<(), String> {
let _guard = restore_mutation_guard().lock().await;
// 1. 停止代理服务器(即使未运行也继续执行恢复逻辑)
if let Err(e) = self.stop_unlocked().await {
if let Err(e) = self.stop().await {
log::warn!("停止代理服务器失败(将继续恢复 Live 配置): {e}");
}
@@ -804,9 +777,8 @@ impl ProxyService {
///
/// 用于程序正常退出时,保留代理状态以便下次启动时自动恢复
pub async fn stop_with_restore_keep_state(&self) -> Result<(), String> {
let _guard = restore_mutation_guard().lock().await;
// 1. 停止代理服务器(即使未运行也继续执行恢复逻辑)
if let Err(e) = self.stop_unlocked().await {
if let Err(e) = self.stop().await {
log::warn!("停止代理服务器失败(将继续恢复 Live 配置): {e}");
}
@@ -1843,54 +1815,8 @@ impl ProxyService {
.map_err(|e| format!("获取代理配置失败: {e}"))
}
/// 更新全局代理配置(统一字段)
pub async fn update_global_proxy_config(
&self,
config: GlobalProxyConfig,
) -> Result<(), String> {
let _guard = restore_mutation_guard().lock().await;
self.db
.update_global_proxy_config(config)
.await
.map_err(|e| format!("保存全局代理配置失败: {e}"))
}
/// 更新指定应用的代理配置(应用级字段)
pub async fn update_proxy_config_for_app(&self, config: AppProxyConfig) -> Result<(), String> {
let _guard = restore_mutation_guard().lock().await;
self.db
.update_proxy_config_for_app(config)
.await
.map_err(|e| format!("保存应用代理配置失败: {e}"))
}
pub async fn set_default_cost_multiplier(
&self,
app_type: &str,
value: &str,
) -> Result<(), String> {
let _guard = restore_mutation_guard().lock().await;
self.db
.set_default_cost_multiplier(app_type, value)
.await
.map_err(|e| format!("保存默认成本倍率失败: {e}"))
}
pub async fn set_pricing_model_source(
&self,
app_type: &str,
value: &str,
) -> Result<(), String> {
let _guard = restore_mutation_guard().lock().await;
self.db
.set_pricing_model_source(app_type, value)
.await
.map_err(|e| format!("保存计费模式来源失败: {e}"))
}
/// 更新代理配置
pub async fn update_config(&self, config: &ProxyConfig) -> Result<(), String> {
let _guard = restore_mutation_guard().lock().await;
// 记录旧配置用于判定是否需要重启
let previous = self
.db
@@ -1975,34 +1901,6 @@ impl ProxyService {
self.server.read().await.is_some()
}
/// 检查当前是否存在会让 WebDAV restore 不安全的本地代理状态
pub async fn has_restore_blocking_proxy_state(&self) -> Result<bool, String> {
if self.is_running().await {
return Ok(true);
}
if self
.db
.has_any_live_backup()
.await
.map_err(|e| format!("读取 live 备份状态失败: {e}"))?
{
return Ok(true);
}
if self.detect_takeover_in_live_configs() {
return Ok(true);
}
if self
.db
.is_live_takeover_active()
.await
.map_err(|e| format!("读取代理接管状态失败: {e}"))?
{
return Ok(true);
}
Ok(false)
}
/// 热更新熔断器配置
///
/// 如果代理服务器正在运行,将新配置应用到所有已创建的熔断器实例
@@ -2043,9 +1941,6 @@ mod tests {
use crate::provider::ProviderMeta;
use serial_test::serial;
use std::env;
use std::sync::atomic::{AtomicBool, Ordering};
use std::sync::Arc;
use std::time::Duration;
use tempfile::TempDir;
struct TempHome {
@@ -2213,191 +2108,6 @@ model = "gpt-5.1-codex"
);
}
#[tokio::test]
#[serial]
async fn has_restore_blocking_proxy_state_is_true_when_live_backup_exists_without_enabled_flag()
{
let _home = TempHome::new();
crate::settings::reload_settings().expect("reload settings");
let db = Arc::new(Database::memory().expect("init db"));
let service = ProxyService::new(db.clone());
db.save_live_backup("claude", "{\"env\":{}}")
.await
.expect("seed live backup");
let config = db
.get_proxy_config_for_app("claude")
.await
.expect("get proxy config");
assert!(
!config.enabled,
"enabled flag should remain false for the stronger-artefact test"
);
assert!(
service
.has_restore_blocking_proxy_state()
.await
.expect("check restore blocking proxy state"),
"live backup should block restore even when enabled is false"
);
}
#[tokio::test]
#[serial]
async fn has_restore_blocking_proxy_state_is_true_when_live_config_residue_exists_without_enabled_flag(
) {
let _home = TempHome::new();
crate::settings::reload_settings().expect("reload settings");
let db = Arc::new(Database::memory().expect("init db"));
let service = ProxyService::new(db.clone());
service
.write_claude_live(&json!({
"env": {
"ANTHROPIC_API_KEY": PROXY_TOKEN_PLACEHOLDER
}
}))
.expect("seed taken-over claude live config");
let config = db
.get_proxy_config_for_app("claude")
.await
.expect("get claude proxy config");
assert!(
!config.enabled,
"enabled flag should remain false for the live-residue test"
);
assert!(
service
.has_restore_blocking_proxy_state()
.await
.expect("check restore blocking proxy state"),
"live config residue should block restore even when enabled is false"
);
}
#[tokio::test]
#[serial]
async fn proxy_config_update_waits_for_restore_mutation_guard() {
let db = Arc::new(Database::memory().expect("init db"));
let service = ProxyService::new(db.clone());
let initial = service.get_config().await.expect("read initial config");
let mut updated = initial.clone();
updated.listen_port = if initial.listen_port == 15721 {
15722
} else {
initial.listen_port + 1
};
let expected_port = updated.listen_port;
let guard = restore_mutation_guard().lock().await;
let completed = Arc::new(AtomicBool::new(false));
let completed_bg = Arc::clone(&completed);
let service_bg = service.clone();
let handle = tokio::spawn(async move {
service_bg
.update_config(&updated)
.await
.expect("update config after guard release");
completed_bg.store(true, Ordering::SeqCst);
});
tokio::time::sleep(Duration::from_millis(150)).await;
assert!(
!completed.load(Ordering::SeqCst),
"config update should wait behind the restore/mutation guard"
);
assert!(
!handle.is_finished(),
"config update task should still be blocked by the guard"
);
drop(guard);
tokio::time::timeout(Duration::from_secs(5), handle)
.await
.expect("config update task should finish after guard release")
.expect("config update task should succeed");
assert_eq!(
service
.get_config()
.await
.expect("read config after guard release")
.listen_port,
expected_port
);
}
#[tokio::test]
#[serial]
async fn start_with_takeover_waits_for_restore_mutation_guard() {
let _home = TempHome::new();
crate::settings::reload_settings().expect("reload settings");
let db = Arc::new(Database::memory().expect("init db"));
let service = ProxyService::new(db.clone());
let provider = Provider::with_id(
"claude-provider".to_string(),
"Claude Provider".to_string(),
json!({
"env": {
"ANTHROPIC_API_KEY": "db-key"
}
}),
Some("claude".to_string()),
);
db.save_provider("claude", &provider)
.expect("save claude provider");
db.set_current_provider("claude", &provider.id)
.expect("set current provider");
service
.write_claude_live(&json!({
"env": {
"ANTHROPIC_API_KEY": "live-key"
}
}))
.expect("seed claude live config");
let guard = restore_mutation_guard().lock().await;
let completed = Arc::new(AtomicBool::new(false));
let completed_bg = Arc::clone(&completed);
let service_bg = service.clone();
let handle = tokio::spawn(async move {
service_bg
.start_with_takeover()
.await
.expect("start with takeover after guard release");
completed_bg.store(true, Ordering::SeqCst);
});
tokio::time::sleep(Duration::from_millis(150)).await;
assert!(
!completed.load(Ordering::SeqCst),
"start_with_takeover should wait behind the restore/mutation guard"
);
assert!(
!handle.is_finished(),
"start_with_takeover task should still be blocked by the guard"
);
drop(guard);
tokio::time::timeout(Duration::from_secs(5), handle)
.await
.expect("start_with_takeover task should complete after guard release")
.expect("start_with_takeover task should succeed");
service
.stop_with_restore()
.await
.expect("cleanup started proxy");
}
#[tokio::test]
#[serial]
async fn sync_claude_token_respects_existing_api_key_field() {
+1 -1
View File
@@ -372,7 +372,7 @@ impl StreamCheckService {
anthropic_to_responses(anthropic_body, Some(&provider.id), is_codex_oauth)
.map_err(|e| AppError::Message(format!("Failed to build test request: {e}")))?
} else if is_openai_chat {
anthropic_to_openai(anthropic_body, Some(&provider.id))
anthropic_to_openai(anthropic_body)
.map_err(|e| AppError::Message(format!("Failed to build test request: {e}")))?
} else {
anthropic_body
-77
View File
@@ -182,7 +182,6 @@ pub async fn upload(
/// Download remote snapshot and apply to local database + skills.
pub async fn download(
db: &crate::database::Database,
proxy_service: &crate::services::ProxyService,
settings: &mut WebDavSyncSettings,
) -> Result<Value, AppError> {
settings.validate()?;
@@ -217,11 +216,6 @@ pub async fn download(
)
.await?;
let _guard = crate::services::proxy::restore_mutation_guard()
.lock()
.await;
ensure_restore_allowed(proxy_service).await?;
// Apply snapshot
apply_snapshot(db, &db_sql, &skills_zip)?;
@@ -239,24 +233,6 @@ pub async fn download(
}))
}
async fn ensure_restore_allowed(
proxy_service: &crate::services::ProxyService,
) -> Result<(), AppError> {
if proxy_service
.has_restore_blocking_proxy_state()
.await
.map_err(AppError::Config)?
{
return Err(localized(
"webdav.sync.restore_blocked_proxy_active",
"当前本地代理或接管状态仍然活跃,请先恢复本地代理状态后再执行 WebDAV 恢复",
"Local proxy or takeover state is still active. Restore local proxy state before running WebDAV restore.",
));
}
Ok(())
}
/// Fetch remote manifest info without downloading artifacts.
pub async fn fetch_remote_info(settings: &WebDavSyncSettings) -> Result<Option<Value>, AppError> {
settings.validate()?;
@@ -693,11 +669,6 @@ fn validate_artifact_size_limit(artifact_name: &str, size: u64) -> Result<(), Ap
#[cfg(test)]
mod tests {
use super::*;
use crate::database::Database;
use crate::provider::Provider;
use crate::services::ProxyService;
use std::sync::Arc;
use tempfile::TempDir;
fn artifact(sha256: &str, size: u64) -> ArtifactMeta {
ArtifactMeta {
@@ -910,52 +881,4 @@ mod tests {
fn validate_artifact_size_limit_accepts_limit_boundary() {
assert!(validate_artifact_size_limit("skills.zip", MAX_SYNC_ARTIFACT_BYTES).is_ok());
}
#[tokio::test]
async fn ensure_restore_allowed_rejects_takeover_artifacts_even_when_enabled_flag_is_false() {
let temp_home = TempDir::new().expect("create temp home");
std::env::set_var("HOME", temp_home.path());
std::env::set_var("USERPROFILE", temp_home.path());
std::env::set_var("CC_SWITCH_TEST_HOME", temp_home.path());
let db = Arc::new(Database::memory().expect("init db"));
let proxy_service = ProxyService::new(db.clone());
let provider = Provider::with_id(
"claude-provider".to_string(),
"Claude Provider".to_string(),
serde_json::json!({
"env": {
"ANTHROPIC_API_KEY": "db-key"
}
}),
Some("claude".to_string()),
);
db.save_provider("claude", &provider)
.expect("save claude provider");
db.set_current_provider("claude", &provider.id)
.expect("set current claude provider");
db.save_live_backup("claude", "{\"env\":{}}")
.await
.expect("seed live backup");
let mut proxy_config = db
.get_proxy_config_for_app("claude")
.await
.expect("get claude proxy config");
proxy_config.enabled = false;
db.update_proxy_config_for_app(proxy_config)
.await
.expect("persist cleared enabled flag");
let err = ensure_restore_allowed(&proxy_service)
.await
.expect_err("live backup should still block restore");
assert!(
err.to_string().contains("restore")
|| err.to_string().contains("恢复")
|| err.to_string().contains("proxy"),
"unexpected error: {err}"
);
}
}
-3
View File
@@ -175,8 +175,6 @@ pub struct AppSettings {
pub show_in_tray: bool,
#[serde(default = "default_minimize_to_tray_on_close")]
pub minimize_to_tray_on_close: bool,
#[serde(default)]
pub use_app_window_controls: bool,
/// 是否启用 Claude 插件联动
#[serde(default)]
pub enable_claude_plugin_integration: bool,
@@ -295,7 +293,6 @@ impl Default for AppSettings {
Self {
show_in_tray: true,
minimize_to_tray_on_close: true,
use_app_window_controls: false,
enable_claude_plugin_integration: false,
skip_claude_onboarding: false,
launch_on_startup: false,
+8 -143
View File
@@ -9,10 +9,6 @@ import {
Plus,
Settings,
ArrowLeft,
Minus,
Maximize2,
Minimize2,
X,
Book,
Wrench,
RefreshCw,
@@ -26,7 +22,6 @@ import {
Shield,
Cpu,
} from "lucide-react";
import { getCurrentWindow } from "@tauri-apps/api/window";
import type { Provider, VisibleApps } from "@/types";
import type { EnvConflict } from "@/types/env";
import { useProvidersQuery, useSettingsQuery } from "@/lib/query";
@@ -104,8 +99,9 @@ interface WebDavSyncStatusUpdatedPayload {
error?: string;
}
const DEFAULT_DRAG_BAR_HEIGHT = isWindows() || isLinux() ? 0 : 28; // px
const DRAG_BAR_HEIGHT = isWindows() || isLinux() ? 0 : 28; // px
const HEADER_HEIGHT = 64; // px
const CONTENT_TOP_OFFSET = DRAG_BAR_HEIGHT + HEADER_HEIGHT;
const STORAGE_KEY = "cc-switch-last-app";
const VALID_APPS: AppId[] = [
@@ -157,17 +153,12 @@ function App() {
const [currentView, setCurrentView] = useState<View>(getInitialView);
const [settingsDefaultTab, setSettingsDefaultTab] = useState("general");
const [isAddOpen, setIsAddOpen] = useState(false);
const [isWindowMaximized, setIsWindowMaximized] = useState(false);
useEffect(() => {
localStorage.setItem(VIEW_STORAGE_KEY, currentView);
}, [currentView]);
const { data: settingsData } = useSettingsQuery();
const useAppWindowControls =
isLinux() && (settingsData?.useAppWindowControls ?? false);
const dragBarHeight = useAppWindowControls ? 32 : DEFAULT_DRAG_BAR_HEIGHT;
const contentTopOffset = dragBarHeight + HEADER_HEIGHT;
const visibleApps: VisibleApps = settingsData?.visibleApps ?? {
claude: true,
codex: true,
@@ -401,51 +392,6 @@ function App() {
};
}, [queryClient, t]);
useEffect(() => {
let active = true;
let unlistenResize: (() => void) | undefined;
const setupWindowStateSync = async () => {
try {
const currentWindow = getCurrentWindow();
const syncWindowMaximizedState = async () => {
const maximized = await currentWindow.isMaximized();
if (active) {
setIsWindowMaximized(maximized);
}
};
await syncWindowMaximizedState();
unlistenResize = await currentWindow.onResized(() => {
void syncWindowMaximizedState();
});
} catch (error) {
console.error("[App] Failed to sync window maximized state", error);
}
};
void setupWindowStateSync();
return () => {
active = false;
unlistenResize?.();
};
}, []);
useEffect(() => {
// settingsData 未加载时跳过,避免用 fallback false 覆盖 Rust 侧已设好的装饰状态
if (!settingsData) return;
const syncWindowDecorations = async () => {
try {
await getCurrentWindow().setDecorations(!useAppWindowControls);
} catch (error) {
console.error("[App] Failed to update window decorations", error);
}
};
void syncWindowDecorations();
}, [useAppWindowControls, settingsData]);
useEffect(() => {
const checkEnvOnStartup = async () => {
try {
@@ -788,44 +734,6 @@ function App() {
}
};
const notifyWindowControlError = (error: unknown) => {
toast.error(
t("notifications.windowControlFailed", {
defaultValue: "窗口控制失败:{{error}}",
error: extractErrorMessage(error),
}),
);
};
const handleWindowMinimize = async () => {
try {
await getCurrentWindow().minimize();
} catch (error) {
console.error("[App] Failed to minimize window", error);
notifyWindowControlError(error);
}
};
const handleWindowToggleMaximize = async () => {
try {
const currentWindow = getCurrentWindow();
await currentWindow.toggleMaximize();
setIsWindowMaximized(await currentWindow.isMaximized());
} catch (error) {
console.error("[App] Failed to toggle maximize", error);
notifyWindowControlError(error);
}
};
const handleWindowClose = async () => {
try {
await getCurrentWindow().close();
} catch (error) {
console.error("[App] Failed to close window", error);
notifyWindowControlError(error);
}
};
const renderContent = () => {
const content = (() => {
switch (currentView) {
@@ -972,57 +880,14 @@ function App() {
return (
<div
className="flex flex-col h-screen overflow-hidden bg-background text-foreground selection:bg-primary/30"
style={{ overflowX: "hidden", paddingTop: contentTopOffset }}
style={{ overflowX: "hidden", paddingTop: CONTENT_TOP_OFFSET }}
>
{(dragBarHeight > 0 || useAppWindowControls) && (
{DRAG_BAR_HEIGHT > 0 && (
<div
className="fixed top-0 left-0 right-0 z-[70] flex items-center justify-end px-2"
className="fixed top-0 left-0 right-0 z-[60]"
data-tauri-drag-region
style={{ WebkitAppRegion: "drag", height: dragBarHeight } as any}
>
{useAppWindowControls && (
<div
className="flex items-center gap-1"
style={{ WebkitAppRegion: "no-drag" } as any}
>
<Button
variant="ghost"
size="icon"
onClick={() => void handleWindowMinimize()}
title={t("header.windowMinimize")}
className="h-7 w-7"
>
<Minus className="w-4 h-4" />
</Button>
<Button
variant="ghost"
size="icon"
onClick={() => void handleWindowToggleMaximize()}
title={
isWindowMaximized
? t("header.windowRestore")
: t("header.windowMaximize")
}
className="h-7 w-7"
>
{isWindowMaximized ? (
<Minimize2 className="w-4 h-4" />
) : (
<Maximize2 className="w-4 h-4" />
)}
</Button>
<Button
variant="ghost"
size="icon"
onClick={() => void handleWindowClose()}
title={t("header.windowClose")}
className="h-7 w-7 hover:bg-red-500/15 hover:text-red-500"
>
<X className="w-4 h-4" />
</Button>
</div>
)}
</div>
style={{ WebkitAppRegion: "drag", height: DRAG_BAR_HEIGHT } as any}
/>
)}
{showEnvBanner && envConflicts.length > 0 && (
<EnvWarningBanner
@@ -1055,7 +920,7 @@ function App() {
style={
{
...DRAG_REGION_STYLE,
top: dragBarHeight,
top: DRAG_BAR_HEIGHT,
height: HEADER_HEIGHT,
} as any
}
@@ -3,7 +3,6 @@ import type { SettingsFormState } from "@/hooks/useSettings";
import { AppWindow, MonitorUp, Power, EyeOff } from "lucide-react";
import { ToggleRow } from "@/components/ui/toggle-row";
import { AnimatePresence, motion } from "framer-motion";
import { isLinux } from "@/lib/platform";
interface WindowSettingsProps {
settings: SettingsFormState;
@@ -76,18 +75,6 @@ export function WindowSettings({ settings, onChange }: WindowSettingsProps) {
onChange({ minimizeToTrayOnClose: value })
}
/>
{isLinux() && (
<ToggleRow
icon={<AppWindow className="h-4 w-4 text-amber-500" />}
title={t("settings.useAppWindowControls")}
description={t("settings.useAppWindowControlsDescription")}
checked={!!settings.useAppWindowControls}
onCheckedChange={(value) =>
onChange({ useAppWindowControls: value })
}
/>
)}
</div>
</section>
);
-3
View File
@@ -81,7 +81,6 @@ export function useSettingsForm(): UseSettingsFormResult {
...data,
showInTray: data.showInTray ?? true,
minimizeToTrayOnClose: data.minimizeToTrayOnClose ?? true,
useAppWindowControls: data.useAppWindowControls ?? false,
enableClaudePluginIntegration:
data.enableClaudePluginIntegration ?? false,
silentStartup: data.silentStartup ?? false,
@@ -106,7 +105,6 @@ export function useSettingsForm(): UseSettingsFormResult {
({
showInTray: true,
minimizeToTrayOnClose: true,
useAppWindowControls: false,
enableClaudePluginIntegration: false,
skipClaudeOnboarding: false,
language: readPersistedLanguage(),
@@ -141,7 +139,6 @@ export function useSettingsForm(): UseSettingsFormResult {
...serverData,
showInTray: serverData.showInTray ?? true,
minimizeToTrayOnClose: serverData.minimizeToTrayOnClose ?? true,
useAppWindowControls: serverData.useAppWindowControls ?? false,
enableClaudePluginIntegration:
serverData.enableClaudePluginIntegration ?? false,
silentStartup: serverData.silentStartup ?? false,
+2 -9
View File
@@ -91,11 +91,7 @@
"switchToChinese": "Switch to Chinese",
"switchToEnglish": "Switch to English",
"enterEditMode": "Enter Edit Mode",
"exitEditMode": "Exit Edit Mode",
"windowMinimize": "Minimize window",
"windowMaximize": "Maximize window",
"windowRestore": "Restore window",
"windowClose": "Close window"
"exitEditMode": "Exit Edit Mode"
},
"provider": {
"tabProvider": "Provider",
@@ -205,8 +201,7 @@
"openclawDefaultModelSet": "Set as default model",
"openclawDefaultModelSetFailed": "Failed to set default model",
"openclawNoModels": "No models configured",
"backfillWarning": "Switched successfully, but failed to save changes back to the previous provider",
"windowControlFailed": "Window control failed: {{error}}"
"backfillWarning": "Switched successfully, but failed to save changes back to the previous provider"
},
"confirm": {
"deleteProvider": "Delete Provider",
@@ -499,8 +494,6 @@
"autoLaunchFailed": "Failed to set auto-launch",
"minimizeToTray": "Minimize to tray on close",
"minimizeToTrayDescription": "When checked, clicking the close button will hide to system tray, otherwise the app will exit directly.",
"useAppWindowControls": "Enable app-level window controls",
"useAppWindowControlsDescription": "Use built-in minimize, maximize/restore, and close buttons in the app header.",
"enableClaudePluginIntegration": "Apply to Claude Code extension",
"enableClaudePluginIntegrationDescription": "When enabled, the VS Code Claude Code extension provider will switch with this app",
"skipClaudeOnboarding": "Skip Claude Code first-run confirmation",
+2 -9
View File
@@ -91,11 +91,7 @@
"switchToChinese": "中国語に切り替え",
"switchToEnglish": "英語に切り替え",
"enterEditMode": "編集モードに入る",
"exitEditMode": "編集モードを終了",
"windowMinimize": "ウィンドウを最小化",
"windowMaximize": "ウィンドウを最大化",
"windowRestore": "ウィンドウを元に戻す",
"windowClose": "ウィンドウを閉じる"
"exitEditMode": "編集モードを終了"
},
"provider": {
"tabProvider": "プロバイダー",
@@ -205,8 +201,7 @@
"openclawDefaultModelSet": "デフォルトモデルに設定しました",
"openclawDefaultModelSetFailed": "デフォルトモデルの設定に失敗しました",
"openclawNoModels": "モデルが設定されていません",
"backfillWarning": "切り替え成功しましたが、前のプロバイダーへの設定保存に失敗しました",
"windowControlFailed": "ウィンドウ操作に失敗しました: {{error}}"
"backfillWarning": "切り替え成功しましたが、前のプロバイダーへの設定保存に失敗しました"
},
"confirm": {
"deleteProvider": "プロバイダーを削除",
@@ -499,8 +494,6 @@
"autoLaunchFailed": "自動起動の設定に失敗しました",
"minimizeToTray": "閉じるときトレイへ最小化",
"minimizeToTrayDescription": "チェックすると閉じるボタンでトレイに隠し、オフならアプリを終了します。",
"useAppWindowControls": "アプリ内ウィンドウボタンを有効化",
"useAppWindowControlsDescription": "有効にすると、アプリヘッダーに最小化・最大化/復元・閉じるボタンを表示します。",
"enableClaudePluginIntegration": "Claude Code 拡張に適用",
"enableClaudePluginIntegrationDescription": "オンにすると VS Code の Claude Code 拡張のプロバイダーも同期します",
"skipClaudeOnboarding": "Claude Code の初回確認をスキップ",
+2 -9
View File
@@ -91,11 +91,7 @@
"switchToChinese": "切换到中文",
"switchToEnglish": "切换到英文",
"enterEditMode": "进入编辑模式",
"exitEditMode": "退出编辑模式",
"windowMinimize": "最小化窗口",
"windowMaximize": "最大化窗口",
"windowRestore": "还原窗口",
"windowClose": "关闭窗口"
"exitEditMode": "退出编辑模式"
},
"provider": {
"tabProvider": "供应商",
@@ -205,8 +201,7 @@
"openclawDefaultModelSet": "已设为默认模型",
"openclawDefaultModelSetFailed": "设置默认模型失败",
"openclawNoModels": "该供应商没有配置模型",
"backfillWarning": "切换成功,但旧供应商配置回填失败,您手动修改的配置可能未保存",
"windowControlFailed": "窗口控制失败:{{error}}"
"backfillWarning": "切换成功,但旧供应商配置回填失败,您手动修改的配置可能未保存"
},
"confirm": {
"deleteProvider": "删除供应商",
@@ -499,8 +494,6 @@
"autoLaunchFailed": "设置开机自启失败",
"minimizeToTray": "关闭时最小化到托盘",
"minimizeToTrayDescription": "勾选后点击关闭按钮会隐藏到系统托盘,取消则直接退出应用。",
"useAppWindowControls": "启用应用级窗口按钮",
"useAppWindowControlsDescription": "开启后使用应用自建的最小化、最大化/还原、关闭按钮;关闭后沿用系统窗口模式。",
"enableClaudePluginIntegration": "应用到 Claude Code 插件",
"enableClaudePluginIntegrationDescription": "开启后 Vscode Claude Code 插件的供应商将随本软件切换",
"skipClaudeOnboarding": "跳过 Claude Code 初次安装确认",
+1 -3
View File
@@ -166,7 +166,7 @@ export interface ProviderMeta {
apiKeyField?: ClaudeApiKeyField;
// 是否将 base_url 视为完整 API 端点(代理直接使用此 URL,不拼接路径)
isFullUrl?: boolean;
// Prompt cache key for OpenAI-compatible endpoints (improves cache hit rate)
// Prompt cache key for OpenAI Responses-compatible endpoints (improves cache hit rate)
promptCacheKey?: string;
// 供应商类型(用于识别 Copilot 等特殊供应商)
providerType?: string;
@@ -244,8 +244,6 @@ export interface Settings {
showInTray: boolean;
// 点击关闭按钮时是否最小化到托盘而不是关闭应用
minimizeToTrayOnClose: boolean;
// 是否启用应用级窗口控制按钮(最小化/最大化/关闭)
useAppWindowControls?: boolean;
// 启用 Claude 插件联动(写入 ~/.claude/config.json 的 primaryApiKey
enableClaudePluginIntegration?: boolean;
// 跳过 Claude Code 初次安装确认(写入 ~/.claude.json 的 hasCompletedOnboarding